Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events.icsをイベントのページから生成するようにした #52

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

events.icsをイベントのページから生成するようにした #52

wants to merge 3 commits into from

Conversation

onokatio
Copy link
Member

今までevents.icsは専用のjsonファイルを作成して管理していたが、代わりに各イベントページの上部のjsonから動的に生成するようにした。
また、一部icalendarの形式を修正した。

@onokatio
Copy link
Member Author

FYI: こんな感じ

VERSION:2.0
PRODID:-//until./until-tsukuba.github.io//NONSGML v1.0//JP
X-WR-TIMEZONE:UTC
BEGIN:VEVENT
UID:ntteast-tunnel-trip
DTSTAMP:20250131T154047Z
DTSTART;VALUE=DATE-TIME:20230323T010000Z
DTEND;VALUE=DATE-TIME:20230323T030000Z
SUMMARY:NTT東日本 洞道見学会
LOCATION:NTT東日本 都内某ビル
URL:https://until-tsukuba.github.io/events/2023/ntteast-tunnel-trip/
END:VEVENT
BEGIN:VEVENT
UID:until-lt0x02
DTSTAMP:20250131T154047Z
DTSTART;VALUE=DATE-TIME:20230601T100000Z
DTEND;VALUE=DATE-TIME:20230601T120000Z
SUMMARY:UNTIL. LT #0x02
LOCATION:グローバルヴィレッジ コミュニティステーション 2F
URL:https://until-tsukuba.github.io/events/2023/until-lt0x02/
END:VEVENT
BEGIN:VEVENT
UID:until-lt0x03
DTSTAMP:20250131T154047Z
DTSTART;VALUE=DATE-TIME:20231203T040000Z
DTEND;VALUE=DATE-TIME:20231203T070000Z
SUMMARY:[UNTIL. LT×学生LT] UNTIL. LT #0x03
LOCATION:筑波大学東京キャンパス文京校舎 3F 337講義室
URL:https://until-tsukuba.github.io/events/2023/until-lt0x03/
END:VEVENT
BEGIN:VEVENT
UID:ntteast-tunnel
DTSTAMP:20250131T154047Z
DTSTART;VALUE=DATE-TIME:20240925T053000Z
DTEND;VALUE=DATE-TIME:20240925T080000Z
SUMMARY:NTT東日本 とう道見学会
LOCATION:NTT東日本 都内某ビル
URL:https://until-tsukuba.github.io/events/2024/ntteast-tunnel/
END:VEVENT
BEGIN:VEVENT
UID:until-lt0x04
DTSTAMP:20250131T154047Z
DTSTART;VALUE=DATE-TIME:20240511T070000Z
DTEND;VALUE=DATE-TIME:20240511T110000Z
SUMMARY:UNTIL. LT #0x04
LOCATION:筑波大学 3A209
URL:https://until-tsukuba.github.io/events/2024/until-lt0x04/
END:VEVENT
BEGIN:VEVENT
UID:until-lt0x05
DTSTAMP:20250131T154047Z
DTSTART;VALUE=DATE-TIME:20241005T070000Z
DTEND;VALUE=DATE-TIME:20241005T110000Z
SUMMARY:UNTIL. LT #0x05
LOCATION:筑波大学筑波キャンパス春日エリア 7A101
URL:https://until-tsukuba.github.io/events/2024/until-lt0x05/
END:VEVENT
BEGIN:VEVENT
UID:until-lt0x06
DTSTAMP:20250131T154047Z
DTSTART;VALUE=DATE-TIME:20250201T070000Z
DTEND;VALUE=DATE-TIME:20250201T110000Z
SUMMARY:UNTIL. LT #0x06
LOCATION:筑波大学筑波キャンパス 3A308
URL:https://until-tsukuba.github.io/events/2025/until-lt0x06/
END:VEVENT
END:VCALENDAR

@onokatio
Copy link
Member Author

onokatio commented Jan 31, 2025 •
edited
Loading

レビューおなしゃす @eniehack @oageo

@oageo oageo self-requested a review February 1, 2025 18:35
oageo
oageo reviewed Feb 1, 2025
View reviewed changes
src/ical.njk
{% if event.url !== undefined %}
URL:{{ event.url }}
{% endif %}
UID:{{ event.page.fileSlug }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slugをUIDとして活用するの、多分正しいがそれで良いかは確認が必要そう

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icalendarの規約的にマズいということですか？

Copy link
Contributor

@oageo oageo Feb 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icalの規格（RFC 5545）的に、UIDの重複は許されておらず、将来的に年度は異なるもののslugが同一な記事（例えば2025/ntt-tunnnelと2026/ntt-tunnnel）が存在しうる状況で採用するのはちょっと怖い、という意味です
ref: https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.4.7

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icalの規格に詳しくないのですが、数字から始まることが許容されるのであれば、UIDには年を頭に付加するなどをしても良いのではないかと思っています

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ〜〜〜なるほど、ユニークさということですね

Copy link
Member

@eniehack eniehack Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ical詳しくない2なのですが、UIDはグローバルにユニークであることが求められている？
https://icalendar.org/New-Properties-for-iCalendar-RFC-7986/5-3-uid-property.html

であるなれば、そのままurlを置いてしまってもよい気もします

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UIDに使って良い文字種がわからないのですが、記号がOKなら確かにURLが良さそう。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.4.7 を見ると、 https://datatracker.ietf.org/doc/html/rfc5545#section-3.3.11 にあるTEXT型の範疇であれば問題なさそう？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eniehack eniehack eniehack left review comments

@oageo oageo oageo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onokatio @eniehack @oageo